Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link boost statically only when requested #2291

Closed
wants to merge 1 commit into from
Closed

Link boost statically only when requested #2291

wants to merge 1 commit into from

Conversation

MarkusTeufelberger
Copy link
Collaborator

Fixes #2261

@ripplelabs-jenkins
Copy link
Collaborator

Jenkins Build Summary

Built from this commit

Built at 20171202 - 21:47:35

Test Results

Build Type Result Status
Author Check MarkusTeufelberger is not a collaborator! FAIL 🔴

@codecov-io
Copy link

Codecov Report

Merging #2291 into develop will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2291      +/-   ##
===========================================
- Coverage    70.96%   70.89%   -0.08%     
===========================================
  Files          691      691              
  Lines        51663    51120     -543     
===========================================
- Hits         36661    36239     -422     
+ Misses       15002    14881     -121
Impacted Files Coverage Δ
src/ripple/beast/clock/chrono_util.h 82.6% <0%> (-8.7%) ⬇️
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%) ⬇️
src/ripple/app/ledger/PendingSaves.h 93.54% <0%> (-6.46%) ⬇️
src/ripple/app/ledger/TransactionStateSF.cpp 50% <0%> (-3.85%) ⬇️
src/ripple/core/SociDB.h 60% <0%> (-3.64%) ⬇️
src/ripple/app/ledger/AcceptedLedger.cpp 66.66% <0%> (-2.09%) ⬇️
src/ripple/beast/utility/WrappedSink.h 54.54% <0%> (-1.98%) ⬇️
src/ripple/nodestore/impl/DatabaseRotatingImp.h 60.52% <0%> (-1.98%) ⬇️
src/ripple/conditions/impl/error.cpp 43.24% <0%> (-1.5%) ⬇️
src/ripple/server/impl/Port.cpp 68.9% <0%> (-1.41%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090d813...5668bda. Read the comment docs.

@JoeLoser
Copy link
Contributor

Any interest in getting this through still @bachase? I saw this PR had no reviewers assigned to it and it's a small, good change.

@bachase
Copy link
Collaborator

bachase commented Dec 20, 2017

@mellery451 and @ximinez feel free to retag, but your cmake preferences are highly weighted!

mellery451
mellery451 approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@mellery451 mellery451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mellery451
Copy link
Contributor

(built using private branch)

Jenkins Build Summary

Built from this commit

Built at 20171220 - 19:02:52

Test Results

Build Type Result Status
coverage 970 cases, 0 failed, t: 610s PASS ✅
clang.debug.unity 970 cases, 0 failed, t: 382s PASS ✅
gcc.debug.unity 970 cases, 0 failed, t: 434s PASS ✅
clang.debug.nounity 968 cases, 0 failed, t: 589s PASS ✅
clang.release.unity 969 cases, 0 failed, t: 469s PASS ✅
gcc.debug.nounity 968 cases, 0 failed, t: 691s PASS ✅
gcc.release.unity 969 cases, 0 failed, t: 499s PASS ✅

@nbougalis nbougalis mentioned this pull request Jan 10, 2018
Merged
@seelabs
Copy link
Collaborator

seelabs commented Jan 16, 2018

In 0.90.0-b3

@seelabs seelabs closed this Jan 16, 2018
@mellery451 mellery451 mentioned this pull request Jun 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mellery451 mellery451 mellery451 approved these changes

@ximinez ximinez Awaiting requested review from ximinez

Assignees

@mellery451 mellery451

@ximinez ximinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MarkusTeufelberger @ripplelabs-jenkins @codecov-io @JoeLoser @bachase @mellery451 @seelabs @ximinez